Skip to content

Use hyphenated ml-intern Trackio prefixes#250

Merged
lewtun merged 2 commits intomainfrom
codex/hyphenate-trackio-prefix
May 8, 2026
Merged

Use hyphenated ml-intern Trackio prefixes#250
lewtun merged 2 commits intomainfrom
codex/hyphenate-trackio-prefix

Conversation

@lewtun
Copy link
Copy Markdown
Member

@lewtun lewtun commented May 8, 2026

Summary

  • Update Trackio dashboard Space examples from mlintern-* to ml-intern-* in the system prompt and tool schemas.
  • Add a regression test that keeps the prompt/tool guidance aligned with the desired hyphenated prefix.
  • Keep trackio_space_id pass-through behavior unchanged: the tools do not rewrite stale or custom IDs.

Testing

  • uv run pytest tests/unit/test_trackio_space_ids.py
  • uv run ruff check .
  • uv run ruff format --check .

lewtun and others added 2 commits May 8, 2026 15:53
Co-authored-by: OpenAI Codex <codex@openai.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Claude finished @lewtun's task in 2m 16s —— View job


PR Review

LGTM — no blocking issues.

This is a surgical doc/spec change: three example strings updated from mlintern- to ml-intern- plus a regression test. I verified:

  • No remaining mlintern references anywhere in the tree (grep -rn 'mlintern' --include='*.py' --include='*.yaml' --include='*.md' --include='*.ts' --include='*.tsx' returns nothing).
  • The two example variants (<8-char-id> in the system prompt, <8char> in the tool specs) are pre-existing inconsistencies — the regression test asserts both spellings, so it won't drift.
  • Pass-through behavior in agent/tools/jobs_tool.py:595-598 and agent/tools/sandbox_tool.py:589-682 is unchanged — no normalization, exactly as the PR description states. The legacy normalize_trackio_space_id helper from the first commit was correctly removed in e4a2f56, so there's no dead code.
  • Examples are consistent across all three call sites: agent/prompts/system_prompt_v3.yaml:69, agent/tools/jobs_tool.py:1119,1210, agent/tools/sandbox_tool.py:545,569.

Findings

P2tests/unit/test_trackio_space_ids.py:9 reads agent/prompts/system_prompt_v3.yaml via a relative path, so it only works when pytest runs from the repo root. This matches the convention used elsewhere in the repo, so not worth changing — just noting for awareness.

P2 — The pass-through choice is intentional and documented in the PR body, but there's no test asserting it. If someone later "fixes" this by adding silent rewriting (as the dropped first commit did), nothing in the test suite would catch the regression. A one-liner asserting args.get("trackio_space_id") is preserved verbatim through the handler would lock in the contract. Optional follow-up.

Tasks

  • Read changed files
  • Verify hyphenated prefix is consistent across the codebase
  • Check that pass-through behavior is preserved
  • Evaluate test coverage
  • Post review
    • Branch: codex/hyphenate-trackio-prefix

@lewtun lewtun merged commit 11112c6 into main May 8, 2026
3 checks passed
@lewtun lewtun deleted the codex/hyphenate-trackio-prefix branch May 8, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant